Make Bruker converters add_to_nwb and run_conversion consistent with all the other converters
#987
+163
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/catalystneuro/neuroconv into second_fix_converter_in_converter_stub
|
I'll let @weiglszonja chime in with their thoughts since this style came up with most of their subconverters |
|
This is not going to be good for converters that a lot of interfaces (altought I think that should not happen) so we should provide some utility function for that. |
Can you elaborate this? I'm not sure I understand the issue enough here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converters core methods
add_to_nwbshould be consistent. This PR deprecates the kwargs mechanism of the bruker converters and substitutes it for passing a dictionary as in all the other cases.This will avoid the need to do introspection in #979