Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #908 #998

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

alessandratrapani
Copy link
Contributor

Fix #908 by adding check on ndx-events version

@alessandratrapani alessandratrapani marked this pull request as ready for review August 12, 2024 10:00
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (b9507bf) to head (b303182).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   91.43%   91.42%   -0.02%     
==========================================
  Files         127      127              
  Lines        7540     7542       +2     
==========================================
+ Hits         6894     6895       +1     
- Misses        646      647       +1     
Flag Coverage Δ
unittests 91.42% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../neuroconv/tools/nwb_helpers/_configure_backend.py 90.90% <100.00%> (-2.64%) ⬇️

@CodyCBakerPhD CodyCBakerPhD requested review from h-mayorquin and removed request for CodyCBakerPhD September 2, 2024 06:12
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, after this PR the objects from ndx-events 3.0 or above will raise an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Conflict in configure_backend function when using ndx-events 0.3.0 and other extesion
3 participants