-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #908 #998
base: main
Are you sure you want to change the base?
Fix #908 #998
Conversation
Co-authored-by: Szonja Weigl <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 91.43% 91.42% -0.02%
==========================================
Files 127 127
Lines 7540 7542 +2
==========================================
+ Hits 6894 6895 +1
- Misses 646 647 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, after this PR the objects from ndx-events 3.0 or above will raise an error?
Fix #908 by adding check on ndx-events version