-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline Docstrings #235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 77.05% 76.98% -0.08%
==========================================
Files 37 37
Lines 2724 2724
==========================================
- Hits 2099 2097 -2
- Misses 625 627 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Have feedback on the report? Share it here. |
So, this looks good to me now as-is @pauladkisson Would you like to merge this in directly (and follow-up PR perhaps enhances them to be even more stringent using a better linter) or wait and find a better linter in this PR? |
We should merge this directly and follow-up. I still think the numpydoc validation pre-commit is going to be our best bet, but getting it to work properly has proved more complicated than I originally thought. Plus, this PR is already pretty substantial. |
Significant Changes