Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workflows #317

Merged
merged 38 commits into from
May 1, 2024
Merged

Update Workflows #317

merged 38 commits into from
May 1, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Apr 29, 2024

  • remove conda
  • x64
  • arm64
  • python 3.12
  • dev tests

@pauladkisson
Copy link
Member Author

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

@CodyCBakerPhD
Copy link
Member

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

Can you ping them about that?

Also you can just add a skip for that on relevant tests, platform.architecture + platform.platform or sys.platform should give you something to use to distnguish skip logic

@pauladkisson
Copy link
Member Author

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

Can you ping them about that?

Done: https://gitlab.com/vidriotech/scanimagetiffreader-python/-/issues/31

@pauladkisson pauladkisson marked this pull request as ready for review April 30, 2024 23:19
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) April 30, 2024 23:25
@pauladkisson
Copy link
Member Author

wait, I'm in the middle of this fix too

@CodyCBakerPhD
Copy link
Member

It looks like the codecov upload action could be updated too

Also looks like current actions don't cancel previous runs on new pushes? Can you add that too everywhere, saves a lot of redundant CI time

@CodyCBakerPhD
Copy link
Member

@pauladkisson
lowercase darwin

I believe platform.system() is upper-case, sys.platform is lower case

You'll just also need a conditional add for https://github.com/catalystneuro/roiextractors/blob/workflow/tests/test_io.py#L48 to the list of IO to test

@pauladkisson
Copy link
Member Author

You'll just also need a conditional add for https://github.com/catalystneuro/roiextractors/blob/workflow/tests/test_io.py#L48 to the list of IO to test

Ah, right, forgot about that one.

@CodyCBakerPhD
Copy link
Member

Looks great, thanks!

@CodyCBakerPhD CodyCBakerPhD merged commit d078f60 into main May 1, 2024
31 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the workflow branch May 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants