-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Workflows #317
Update Workflows #317
Conversation
pauladkisson
commented
Apr 29, 2024
•
edited
Loading
edited
- remove conda
- x64
- arm64
- python 3.12
- dev tests
Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them? |
Can you ping them about that? Also you can just add a skip for that on relevant tests, |
Done: https://gitlab.com/vidriotech/scanimagetiffreader-python/-/issues/31 |
for more information, see https://pre-commit.ci
wait, I'm in the middle of this fix too |
It looks like the codecov upload action could be updated too Also looks like current actions don't cancel previous runs on new pushes? Can you add that too everywhere, saves a lot of redundant CI time |
I believe You'll just also need a conditional add for https://github.com/catalystneuro/roiextractors/blob/workflow/tests/test_io.py#L48 to the list of IO to test |
Ah, right, forgot about that one. |
Looks great, thanks! |