Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter process to handle not-filter expressions #20

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

catatsuy
Copy link
Owner

This pull request primarily introduces a new feature to the CLI struct in the cli/cli.go file, which allows the user to specify not only filters but also not-filters when running the CLI. This new feature is reflected in the Run, parseFlags, validateInput, and filterProcess functions. Additionally, a helper function matchesFilters was added to handle the filter matching logic. The test files cli/cli_test.go and cli/export_test.go were updated to reflect these changes and to ensure the new feature works as expected.

New Feature: Not-Filters

  • cli/cli.go: Added a new member notFilters to the CLI struct. Modified the Run, parseFlags, validateInput, and filterProcess functions to handle the new notFilters feature. Added a new helper function matchesFilters to handle the filter matching logic. [1] [2] [3] [4] [5] [6]

Test Updates:

  • cli/cli_test.go: Renamed some test functions and added new test cases to cover the new not-filter feature. Modified the TestFilterProcess function to handle the new filters and notFilters parameters. [1] [2] [3] [4] [5]
  • cli/export_test.go: Updated the FilterProcess function to handle the new filters and notFilters parameters.

@catatsuy catatsuy merged commit 41a7322 into main Mar 30, 2024
1 check passed
@catatsuy catatsuy deleted the feature_add_not_filter branch March 30, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant