refactor: consistent failed var names

scripts/lint/main.ts

@@ -20,7 +20,7 @@ const stylesheets = walk(join(REPO_ROOT, "styles", subDir), {
   match: [/\.user.css$/],
 });
 
-let errored;
+let failed;
 
 for await (const entry of stylesheets) {
   const repodir = dirname(entry.path);
@@ -37,7 +37,7 @@ for await (const entry of stylesheets) {
   // try to compile the less file, report any errors
   less.render(content, { lint: true, globalVars }).then().catch(
     (err) => {
-      errored = true;
+      failed = true;
       log(
         err.message,
         { file, startLine: err.line, endLine: err.line, content },
@@ -48,15 +48,15 @@ for await (const entry of stylesheets) {
 
   // advanced linting with stylelint
   if (await lint(entry, content, flags.fix) === false) {
-    errored = true;
+    failed = true;
   }
 }
 
 // if any files are missing, cause the workflow to fail
 if (await checkForMissingFiles() === false) {
-  errored = true;
+  failed = true;
 }
 
-if (errored) {
+if (failed) {
   Deno.exit(1);
 }

scripts/lint/stylelint.ts

@@ -13,13 +13,13 @@ import { log } from "@/lint/logger.ts";
 export const lint = async (entry: WalkEntry, content: string, fix: boolean) => {
   const file = relative(REPO_ROOT, entry.path);
 
-  let success = true;
+  let failed = false;
 
   await stylelint.lint({ files: entry.path, fix })
     .then(({ results }) => {
       results.map((result) => {
         if (result.warnings.length > 0) {
-          success = false;
+          failed = true;
         }
 
         result.warnings.map((warning) => {
@@ -41,5 +41,5 @@ export const lint = async (entry: WalkEntry, content: string, fix: boolean) => {
       });
     });
 
-  return success;
+  return !failed;
 };