Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple-developer-documentation): init #1044

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

AyaanAhmed25
Copy link

@AyaanAhmed25 AyaanAhmed25 commented Jul 4, 2024

🎉 Theme for Apple developer documentation 🎉

Apple's official documentation site.

preview

💬 Additional Comments 💬

Was unsure whether to make the link colors accent-color or blue, went with blue in the end. Feel free to change.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots stitched together,
      generated via Catwalk.

@AyaanAhmed25 AyaanAhmed25 requested a review from a team as a code owner July 4, 2024 03:55
@AyaanAhmed25 AyaanAhmed25 changed the title Feat/apple developer feat(apple-developer): init Jul 4, 2024
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/apple-developer/catppuccin.user.css Outdated Show resolved Hide resolved
styles/apple-developer/catppuccin.user.css Outdated Show resolved Hide resolved
styles/apple-developer/catppuccin.user.css Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

uncenter commented Jul 4, 2024

Please rename the styles/apple-developer/ directory to styles/apple-developer-documentation.

@AyaanAhmed25
Copy link
Author

@uncenter
do you want me to rename apple-developer to apple-developer-documentation everywhere?

@AyaanAhmed25 AyaanAhmed25 changed the title feat(apple-developer): init feat(apple-developer-documentation): init Jul 4, 2024
@isabelroses
Copy link
Member

do you want me to rename apple-developer to apple-developer-documentation everywhere?A

Yes, you should.

@isabelroses
Copy link
Member

Also please try to fix the linter errors, most should be easy with deno task lint:fix

@uncenter uncenter marked this pull request as draft July 4, 2024 14:28
@AyaanAhmed25
Copy link
Author

@uncenter Im sorry for all the delays im new to this stuff. Is there anything I need to do now? I see in the reviews section it says 1 change requested, but I dont see anything regarding the change itself
Screenshot 2024-07-04 at 10 57 43 AM

@uncenter
Copy link
Member

uncenter commented Jul 4, 2024

I'm seeing a lot of unthemed variables. Can you add colors to them?

@sgoudham
Copy link
Contributor

Hey @AyaanAhmed25 👋

Are you still interested in continuing your work here? @uncenter's comment suggests that there are still some variables to be themed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants