-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(netscape): init #1235
base: main
Are you sure you want to change the base?
feat(netscape): init #1235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about metadata and extra comments, but in general with the main styling I'm seeing a lot of unorganized classes grouped together arbitrarily, and lots of selectors without comments that don't make it clear what they theme (e.g. #hdrLf
). I'd recommend you look through existing userstyles to see how me and other authors/maintainers keep userstyles organized, be it top to bottom of the page (header, body, then footer), or by basic elements first and more specific stuff further down, etc.
Co-authored-by: uncenter <[email protected]>
i can try my best since i wrote half and then imported the other half. (also cause they are all short-worded classNames/ID's) |
Make sure to update that metadata in the UsercCSS comment as well, with the name change. |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very messy overall. Lots of random newlines separating content for no reason, commented out code, a lot of div.xyz
for whatever reason - just use .xyz
if it is clear by the classname/ID. Also please format it with Prettier (format on save is a godsend, use it).
|
🎉 Theme for netscape 🎉
an old netscape site with news.
💬 Additional Comments 💬
images are currently unthemed and have no idea how to theme them atm.
Ill generate preview before merge.
Closes catppuccin/catppuccin#1841
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.