Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arch-linux): init #1381

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

claymorwan
Copy link

🎉 Theme for Arch user repository 🎉

The Arch user repository (aur) is a community-driven repository of packages for Arch Linux.
image

💬 Additional Comments 💬

I had a bit of struggle making this theme since it was my first time working with userstyles, but I made it in a day so it's fine. My only problem at the moment is changing the logo for a themed one, or at least a transparent one.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@claymorwan claymorwan requested a review from a team as a code owner October 16, 2024 23:09
@claymorwan claymorwan changed the title feat/arch-user-repository feat:arch-user-repository Oct 16, 2024
@claymorwan claymorwan changed the title feat:arch-user-repository feat: arch-user-repository Oct 16, 2024
@uncenter uncenter changed the title feat: arch-user-repository feat(arch-user-repository): init Oct 17, 2024
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
@GenShibe
Copy link
Contributor

In terms of the logo, my first thought is to take the SVG off of the arch wiki style, and then using that as a base to add the words "user repository"

@claymorwan
Copy link
Author

Well I already took the argo logo and changed the accent color, tho I haven't been able to insert it correctly and hide the original logo

Btw I think I gotta do a new commit to fix the requested changes or nah ? I don't do pr often so idk

@claymorwan
Copy link
Author

Ok I think I got everything fixed

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for the PR :).

It would be nice to theme visited links.

The red here is not catppuccin themed.
image

Package keywords are a bit hard to read, and would likely be worse if my accent matched the blue, could we use crust on those.
image

styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
styles/arch-user-repository/catppuccin.user.css Outdated Show resolved Hide resolved
@claymorwan
Copy link
Author

I think I fixed everything now, tho idk about that conflict, tried to fix it by adding what was conflicting to the file

@claymorwan
Copy link
Author

I think I fixed everything now, tho idk about that conflict, tried something but didn't worked

@claymorwan
Copy link
Author

why's it broken again

scripts/userstyles.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stylus Stylus label Oct 23, 2024
@github-actions github-actions bot added the arch-wiki Arch Wiki label Oct 23, 2024
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Show resolved Hide resolved
@uncenter uncenter changed the title feat(arch-user-repository): init feat(arch-linux): init Oct 24, 2024
@claymorwan
Copy link
Author

So like, is it good now ? Or is there something else to change ?

@uncenter
Copy link
Member

At the core yes. I'm still seeing some unthemed or incorrectly themed things:

On a page like https://archlinux.org/download/, https://aur.archlinux.org/packages/follow-appimage, or just https://archlinux.org/packages/, the primary layer is the box in the center, which should have a background of base instead of surface1. Area around the box should be mantle.

The text of the current page/tab in the header is unthemed.
CleanShot 2024-10-24 at 10 39 29

On the home page, wiki, and security page: lots of unthemed dashed/solid horizontal lines/borders.

CleanShot 2024-10-24 at 10 40 29
CleanShot 2024-10-24 at 10 41 17
CleanShot 2024-10-24 at 10 42 00

High vulnerability severity text on the security page is unthemed (should be peach, class is .orange):

CleanShot 2024-10-24 at 10 42 18

@claymorwan
Copy link
Author

claymorwan commented Oct 24, 2024

On a page like https://archlinux.org/download/, https://aur.archlinux.org/packages/follow-appimage, or just https://archlinux.org/packages/, the primary layer is the box in the center, which should have a background of base instead of surface1. Area around the box should be mantle.

So you mean change every .box to have base as background, and every background of the page as mantle ?
Like that ?
image

On the home page, wiki, and security page: lots of unthemed dashed/solid horizontal lines/borders.

Been trying to theme these but I have no idea how to, tried border-color but nah

@uncenter
Copy link
Member

So you mean change every .box to have base as background, and every background of the page as mantle ?

Yep just like that.

Been trying to theme these but I have no idea how to, tried border-color but nah

border-bottom-color of: #news h4 for the dotted ones. .mw-heading1, h1, .mw-heading2, h2 for the solid wiki ones.

@claymorwan
Copy link
Author

Chat is it gud

@GitMuslim
Copy link
Member

I'm not sure why you've requested a review from me, but either way looks good.

Though I thought we already had an aur theme, or was that for the wiki?

@uncenter
Copy link
Member

uncenter commented Oct 25, 2024

I'm not sure why you've requested a review from me, but either way looks good.

Though I thought we already had an aur theme, or was that for the wiki?

They accidentally deleted the folder for the Stylus userstyle, triggering the CI to request a review from you since you maintain that.

And yes we did, it was for the wiki. If you follow the chain of events above I suggested combining the proposed Arch User Repository userstyle with the existing Arch Wiki userstyle to create a unified Arch Linux userstyle, and that is what we have now here.

@sgoudham sgoudham removed the request for review from GitMuslim October 25, 2024 19:19
@GitMuslim
Copy link
Member

I suggested combining the proposed Arch User Repository userstyle with the existing Arch Wiki userstyle to create a unified Arch Linux userstyle, and that is what we have now here.

Sounds good.

@claymorwan
Copy link
Author

So do I have to do stuff again for the pr or nah ?

@uncenter
Copy link
Member

So do I have to do stuff again for the pr or nah ?

Nothing right now, just needs reviewing.

@claymorwan
Copy link
Author

So do I have to do stuff again for the pr or nah ?

Nothing right now, just needs reviewing.

Oki, I'll be waiting then

@claymorwan
Copy link
Author

O wairt bu reviewing does that mean Inhabe to do the "request review" thingy

@uncenter
Copy link
Member

uncenter commented Nov 1, 2024

Nope, nothing you need to do right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wiki Arch Wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants