Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lichess): init #346

Merged
merged 36 commits into from
Nov 22, 2023
Merged

feat(lichess): init #346

merged 36 commits into from
Nov 22, 2023

Conversation

coopw1
Copy link
Contributor

@coopw1 coopw1 commented Nov 20, 2023 •
edited
Loading

🎉 Theme for lichess.org🎉

'Lichess is a free and open-source Internet chess server run by a non-profit organization of the same name.'

mocha
wooo

💬 Additional Comments 💬

Forever ago, but was requested here

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • assets/mocha.webp, assets/macchiato.webp, assets/frappe.webp and
      assets/latte.webp - individual screenshots of the themed website, in all 4
      Catppuccin flavors.
    • catwalk.webp - image of all individual screenshots stitched together,
      generated via catwalk.

@coopw1 coopw1 changed the title Feat/lichess.org feat(lichess.org): init Nov 20, 2023
@coopw1
Copy link
Contributor Author

coopw1 commented Nov 20, 2023

Thats not a typo smhh

uncenter
uncenter requested changes Nov 20, 2023
View reviewed changes
styles/lichess.org/catppuccin.user.css Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
@coopw1 coopw1 changed the title feat(lichess.org): init feat(lichess): init Nov 20, 2023
@coopw1
Copy link
Contributor Author

coopw1 commented Nov 20, 2023

I'm heading to sleep, I'll look over stuff again in the morningg

@coopw1
Copy link
Contributor Author

coopw1 commented Nov 20, 2023 •
edited
Loading

Should I bother changing .typos.toml to make it not mark "analyse" as a typo? Or just leave the failed check there

@uncenter
Copy link
Member

It shouldn't spell-check classes since you can't control those... @nekowinston?

@coopw1
Update catppuccin.user.css
0947632 
Fixing a broken dialog box, and getting rid of the unneeded group
@coopw1
Fixing up game selection menu
9ef576e
@coopw1
Removing small bit of useless junk
a5dbd2c
@coopw1
Fixed background
e0c57d6 
I'm a bit dum, idk why I though that was how it worked
@nekowinston
Copy link
Contributor

nekowinston commented Nov 20, 2023 •
edited
Loading

It shouldn't spell-check classes since you can't control those... @nekowinston?

Typos isn't syntax-aware AFAIK, so we don't really have control there, I think.

Edit: oh nvm it's dying on #analyse-cm not .analyse__clock, we can fix that.

@nekowinston nekowinston mentioned this pull request Nov 20, 2023
Merged
@nekowinston
Copy link
Contributor

That fixed it

@nekowinston
Copy link
Contributor

Now the linter's happy. 🙂
Sorry about this causing delays, but the lint setup is a pretty recent addition to this repo. 😅

@nekowinston
Copy link
Contributor

nekowinston commented Nov 21, 2023 •
edited
Loading

I think the contrast was a bit lacking so I styled the chess pieces & board:
2023-11-21-110719@2x

If you don't agree with some of the color choices, we can use the #piece(@f, @s) (fill/stroke) mixin to change them easily.

isabelroses
isabelroses requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best if the buttons used crust for text upon hover shown here
image

styles/lichess/catppuccin.user.css Show resolved Hide resolved
styles/lichess/catppuccin.user.css Show resolved Hide resolved
nekowinston
nekowinston reviewed Nov 21, 2023
View reviewed changes
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
styles/lichess/catppuccin.user.css Outdated Show resolved Hide resolved
coopw1 and others added 4 commits November 21, 2023 12:38
@coopw1 @nekowinston
Apply suggestions from code review
2150c33 
Change method of getting see-through assests

Co-authored-by: winston <[email protected]>
@coopw1 @isabelroses
Update styles/lichess/catppuccin.user.css
a6bed42 
Fix quick pairing hover

Co-authored-by: Isabel <[email protected]>
@coopw1
Update catppuccin.user.css
38bc899 
Removing old hover, changing fadeout to fade for consistency
@coopw1
Update catppuccin.user.css
5bcd44f 
Changed hover color for supporter buttons to mantle
@coopw1
Copy link
Contributor Author

coopw1 commented Nov 21, 2023

I think it would be best if the buttons used crust for text upon hover shown here image

Done!

@coopw1
Copy link
Contributor Author

coopw1 commented Nov 21, 2023

I think the contrast was a bit lacking so I styled the chess pieces & board: 2023-11-21-110719@2x

If you don't agree with some of the color choices, we can use the #piece(@f, @s) (fill/stroke) mixin to change them easily.

Looks good to me

@coopw1
Update styles/lichess/catppuccin.user.css
7abe7e2 
capitalize Lichess
@coopw1
Update catppuccin.user.css
0ccb8de 
Added light/dark mode options to automatically pick
@coopw1
Update styles/lichess/catppuccin.user.css
00be5e2 
Make .org on logo colored to normal text
@coopw1
Merge branch 'main' into feat/lichess.org
f4b979e
@isabelroses @uncenter
fix(lichess): caps
4aa44dd 
Co-authored-by: uncenter <[email protected]>
@uncenter
Copy link
Member

LGTM!

@isabelroses isabelroses merged commit ae9bce5 into catppuccin:main Nov 22, 2023
4 checks passed
@coopw1 coopw1 deleted the feat/lichess.org branch November 22, 2023 18:27
@uncenter uncenter mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter approved these changes

@nekowinston nekowinston nekowinston left review comments

@isabelroses isabelroses isabelroses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coopw1 @uncenter @nekowinston @isabelroses