Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(import-styles): init #399

Merged
merged 33 commits into from
Dec 15, 2023
Merged

feat(import-styles): init #399

merged 33 commits into from
Dec 15, 2023

Conversation

isabelroses
Copy link
Member

  • Allows for a mass import of userstyles.
  • We can enforce settings upon users making our lives easier.

uncenter
uncenter reviewed Dec 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@isabelroses @uncenter
fix: ci paths
5ef4a19 
Co-authored-by: uncenter <[email protected]>
uncenter
uncenter reviewed Dec 13, 2023
View reviewed changes
deno.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added chess.com Chess.com github GitHub labels Dec 13, 2023
@isabelroses
Copy link
Member Author

isabelroses commented Dec 14, 2023 •
edited
Loading

This PR will need refactoring as of #400 being merged

@uncenter uncenter mentioned this pull request Dec 14, 2023
Merged
sgoudham
sgoudham previously requested changes Dec 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
nekowinston
nekowinston suggested changes Dec 15, 2023
View reviewed changes
scripts/import-styles/main.ts Outdated Show resolved Hide resolved
.github/workflows/generate-import.yml Outdated Show resolved Hide resolved
styles/github/catppuccin.user.css Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the github GitHub label Dec 15, 2023
nekowinston
nekowinston suggested changes Dec 15, 2023
View reviewed changes
scripts/import-styles/main.ts Outdated Show resolved Hide resolved
scripts/import-styles/main.ts Outdated Show resolved Hide resolved
@nekowinston

This comment was marked as resolved.

Sign in to view
nekowinston
nekowinston approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@nekowinston nekowinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The last thing we need to do is create that release that we're continuously uploading to.
import-styles for the name seems a bit vague? stylus-backup? latest? nightly? I don't know really.

@isabelroses
Copy link
Member Author

isabelroses commented Dec 15, 2023 •
edited
Loading

import-styles for the name seems a bit vague? stylus-backup? latest? nightly? I don't know really.

I quite like what @uncenter been referring to it as, "stylus export", beyond that i'm unsure either.

@sgoudham
Copy link
Contributor

sgoudham commented Dec 15, 2023 •
edited
Loading

Why can't we name it what it is, all-userstyles-export? all-userstyles-backup? all-userstyles?
Just throwing out suggestions in case it sparks a lightbulb idea for anyone else.

@uncenter
Copy link
Member

I vote for all-userstyles-export!

@isabelroses
Copy link
Member Author

I vote for all-userstyles-export!

This makes sense also has my vote.

@nekowinston
Copy link
Contributor

i don't care

nekowinston
nekowinston reviewed Dec 15, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nekowinston
Copy link
Contributor

nekowinston commented Dec 15, 2023 •
edited
Loading

I've marked it as a pre-release, tag is up: https://github.com/catppuccin/userstyles/releases/tag/all-userstyles-export

The tag doesn't matter, we won't have to update it. Should be good to merge.

@isabelroses isabelroses merged commit a789798 into main Dec 15, 2023
6 checks passed
@isabelroses isabelroses deleted the ci/gen-import branch December 15, 2023 15:37
@isabelroses
Copy link
Member Author

The CI is failing https://github.com/catppuccin/userstyles/actions/runs/7224061024/job/19684480303, due to a lack of GH_TOKEN.

@nekowinston
Copy link
Contributor

And here I was worried that it was going to work in a single commit 🙃

Would you mind fixing it?

@isabelroses
Copy link
Member Author

Would you mind fixing it?

I would have done it already but i had to run. Should be able to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter requested changes

@nekowinston nekowinston nekowinston approved these changes

@coldenate coldenate coldenate approved these changes

@pocco81 pocco81 Awaiting requested review from pocco81

@GlowingUmbreon GlowingUmbreon Awaiting requested review from GlowingUmbreon

@skelebro1 skelebro1 Awaiting requested review from skelebro1

@sgoudham sgoudham Awaiting requested review from sgoudham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isabelroses @nekowinston @sgoudham @uncenter @coldenate