Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(brave-search): rewrite #715

Merged
merged 7 commits into from
Mar 31, 2024
Merged

refactor(brave-search): rewrite #715

merged 7 commits into from
Mar 31, 2024

Conversation

uncenter
Copy link
Member

🔧 What does this fix? 🔧

Closes #713. Seems like a bunch of things changed and the vars weren't right anymore, started changing and decided to start fresh.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@github-actions github-actions bot added the brave-search Brave Search label Mar 25, 2024
@uncenter
Copy link
Member Author

@ndsboy feel free to take over this PR seeing as you are the actual maintainer :D

@ndsboy
Copy link
Contributor

ndsboy commented Mar 30, 2024

Hi @uncenter, sorry for the late reply, GitHub did not send me a notification for this one...
Thank you very much for your rewrite, the base looks great, however I felt like changing the container color to base and adding a more prominent border aligns more with the default brave design and with the other designs.

I've also changed up the icon code a bit, so now the icon and tab color changes depending on your accent color (like reddit or youtube).

Please let me know what you think of these changes :)

@uncenter
Copy link
Member Author

uncenter commented Mar 30, 2024

Hi @uncenter, sorry for the late reply, GitHub did not send me a notification for this one... Thank you very much for your rewrite, the base looks great, however I felt like changing the container color to base and adding a more prominent border aligns more with the default brave design and with the other designs.

I've also changed up the icon code a bit, so now the icon and tab color changes depending on your accent color (like reddit or youtube).

Please let me know what you think of these changes :)

No worries! It is still marked as a draft pull request which is why you didn't get a notification for this. I totally agree with your changes (and this is your userstyle anyway xD).

@ndsboy ndsboy marked this pull request as ready for review March 31, 2024 09:57
@ndsboy ndsboy self-requested a review as a code owner March 31, 2024 09:57
Copy link
Contributor

@ndsboy ndsboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @uncenter for your contribution!

@ndsboy ndsboy merged commit a735015 into main Mar 31, 2024
6 checks passed
@ndsboy ndsboy deleted the refactor/brave-rewrite branch March 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brave-search Brave Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Search is no longer themed
2 participants