Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snakefmt footprints in code #135

Closed
gordonkoehn opened this issue Aug 3, 2023 · 1 comment · Fixed by #151
Closed

Remove snakefmt footprints in code #135

gordonkoehn opened this issue Aug 3, 2023 · 1 comment · Fixed by #151
Assignees
Labels
action: refactor Refactoring the code and adding new tests ❗priority: low ⏰ time estimate: S

Comments

@gordonkoehn
Copy link
Collaborator

I tried out the black-like code formatter for snakemake called snakefmt.

It turns out they are having quite some problems with python run directives in the rules.

It was not usable with built tests and pre-commit hooks as it was not reliable - would break the code sometimes.

Issues where reported to the developers yet it does not seem to be too actively maintained.

See

I removed it, therefore - but some comments remain to be removed.

These commented-out lines in the requirements and github workflows will be removed here.

@gordonkoehn gordonkoehn added action: refactor Refactoring the code and adding new tests ❗priority: low ⏰ time estimate: S labels Aug 3, 2023
@gordonkoehn gordonkoehn self-assigned this Aug 3, 2023
@gordonkoehn
Copy link
Collaborator Author

@pawel-czyz FYI, I tried snakefmt - I do not recommend it in the current state. Glad, to have learned pre-commit hooks and GitHub-built actions though.

@gordonkoehn gordonkoehn linked a pull request Aug 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: refactor Refactoring the code and adding new tests ❗priority: low ⏰ time estimate: S
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant