Make portal screen reader friendly #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshay2905 file changes ? |
|
Empty commit to create a hook for PR. As this would take sometime. Lets do it in phases. I would start with Hompage. |
|
👍 |
heaven00
reviewed
Jul 11, 2017
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| {% block header_logo %} | |||
| {% if g.site_logo %} | |||
| <a class="logo" href="{{ h.url('home') }}"><img src="{{ h.url_for_static_or_external(g.site_logo) }}" alt="{{ g.site_title }}" title="{{ g.site_title }}" /></a> | |||
| <a class="logo" href="{{ h.url('home') }}"><img src="{{ h.url_for_static_or_external(g.site_logo) }}" alt="Open Budgets India header logo" title="{{ g.site_title }}" /></a> | |||
There was a problem hiding this comment.
The purpose of alt and title are different. Thus they aren't suppose to have same content. Also as alt is used highly in screen readers, SEO and for other purposes. Wanted to have a better description for the logo than just "OpenBudgetsIndia" which is the title.
heaven00
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue - #37
Make pages that aren't compatible with Screen Reader mostly because of missing alternative text for images and labels for search bars.