p4est_file: Accept new MPI error codes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-griesbach
force-pushed
the
feature-mpi-errcodes
branch
from
bc44a13
to
f1b9d10
Compare
|
I rebased the branch to remove the libsc update from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p4est_file: Accept new MPI error codes
Currently, the function
p4est_file_error_codedoes not accept MPI error codes that we do not expect according to our wrapped MPI error codes. However, error codes depend on the concrete MPI implementation and in particular newer MPI implementation may cause returning error codes that can not be interpreted in the current way , which currently leads to an abort.Proposed changes: Instead of calling
SC_ABORT_NOT_REACHED ()in the case of an unkown error code we always translate such error codes toP{4,8}EST_FILE_ERR_UNKOWN.