Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature soversion #272

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Feature soversion #272

merged 2 commits into from
Jan 17, 2024

Conversation

cburstedde
Copy link
Owner

Read SOVERSION from configuration file.

We place the library API version by the libtool convention in one global configuration file.
This is sourced from both the autoconf and cmake build processes.

In passing increase the CI runtime for CMake on MacOS from 20 to 25 minutes.

@cburstedde
Copy link
Owner Author

We may need to add at least this one new file in config/ to cpack, and the rest of the directory too if not already included.

@tim-griesbach
Copy link
Collaborator

We may need to add at least this one new file in config/ to cpack, and the rest of the directory too if not already included.

In cmake/install.cmake, we have

# not .gitignore as its regex syntax is more advanced than CMake
set(CPACK_SOURCE_IGNORE_FILES .git/ .github/ .vscode/ _CPack_Packages/
${CMAKE_BINARY_DIR}/ ${PROJECT_BINARY_DIR}/
Makefile.in
aclocal.m4
autom4te.cache/
build/
build-aux/ar-lib
build-aux/compile
build-aux/config.guess
build-aux/config.sub
build-aux/depcomp
build-aux/install-sh
build-aux/ltmain.sh
build-aux/missing
build-aux/test-driver
config/libtool.m4
config/ltoptions.m4
config/ltsugar.m4
config/ltversion.m4
config/lt~obsolete.m4
configure
src/sc_config_autotools.h.in
scindent
scspell
)

Therefore, I think that the new file in config/ should be already included.

Copy link
Collaborator

@tim-griesbach tim-griesbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@cburstedde
Copy link
Owner Author

Let's go back later to the whole cpack structure when we're rechecking #103.

@cburstedde cburstedde merged commit 057eecc into develop Jan 17, 2024
32 checks passed
@cburstedde cburstedde deleted the feature-soversion branch January 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants