cmake: simplify by not using FetchContent #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using add_subdirectory() eliminates unnecessary overhead of FetchContent. This allows users to switch mpi on/off more easier with the --fresh CMake option, rather than having to manually delete the build directory.
|
Thanks! Looking forward to further integration. Is there a way to eliminate the transient CI failures? They have been occurring with almost every update over the last couple weeks. I'm just puzzled since that never happens with autoconf. It would be great to be able to rely on this for the CMake CI as well. |
|
Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using add_subdirectory() eliminates unnecessary overhead of FetchContent. This allows users to switch mpi on/off more easier with the --fresh CMake option, rather than having to manually delete the build directory.
This doesn't change anything from end-users perspective other than that it's easier to use with less files in the build directory.