Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License CC:T according to the REUSE specification #1351

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

SquidDev
Copy link
Member

@SquidDev SquidDev commented Mar 1, 2023

This is the initial stage of the relicensing work, as set out in #1339.

This adds SPDX license headers to all source code files, following the REUSE specification. This does not include any asset files (such as generated JSON files, or textures). While REUSE does support doing so with ".license" files, for now we define these licences using the .reuse/dep5 file.

Any files where I am the only contributor I've licenced as MPL-2.0, copyright "The CC: Tweaked developers". I think this is a little more friendly than "Jonathan Coates and contributors", but open to comments!

All other files are under the CCPL (as before), either copyright "The CC: Tweaked developers" (when this code does not stem from Dan) and "Daniel Ratcliffe" otherwise.

These headers have been updated on a best-effort basis and SHOULD NOT be taken as accurate at this stage. There's about 1k files in this changelog, so while I have been careful, no doubt some things will have slipped through the gaps.


My plan is to let this sit for two weeks1 to give me time to do another audit of these changes, and hopefully gather some further comments here or in #1339. Again, I'm no expert in software licensing, so thoughts welcome!

Footnotes

  1. All going well, planning to merge this on 16th March. I'm giving an exact date here mostly to force myself not to rush this through.

This adds SPDX license headers to all source code files, following the
REUSE[1] specification. This does not include any asset files (such as
generated JSON files, or textures). While REUSE does support doing so
with ".license" files, for now we define these licences using the
.reuse/dep5 file.

[1]: https://reuse.software/
@SquidDev SquidDev added the feedback wanted Tell me what you want, what you really really want. label Mar 1, 2023
@SquidDev SquidDev added this to the 1.104.0 milestone Mar 14, 2023
@SquidDev
Copy link
Member Author

I was on planning on merging this tomorrow, but it's the 16th in half the world and I think it's funny to merge this on the Ides of March. Off to the senate to assassinate the CCPL, yada yada.

@SquidDev SquidDev marked this pull request as ready for review March 15, 2023 21:52
@SquidDev SquidDev merged commit 895bc77 into mc-1.19.x Mar 15, 2023
@SquidDev SquidDev deleted the feature/reuse branch March 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Tell me what you want, what you really really want.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant