handling for bad user mappings

sync-jira/src/main/kotlin/gropius/sync/jira/JiraDataService.kt

@@ -161,17 +161,49 @@ class JiraDataService(
             .firstOrNull { it.name == name }
     }
 
+    /**
+     * Generate a new IMSUser to be a placeholder in erroneous situations
+     * @param imsProject the project to map the user to
+     * @return the created IMSUser
+     */
+    private suspend fun generateNullUser(imsProject: IMSProject, name: String, displayName: String): IMSUser {
+        val foundImsUser = imsProject.ims().value.users().firstOrNull { it.username == name }
+        if (foundImsUser != null) {
+            return foundImsUser
+        }
+        val imsUser = IMSUser(
+            displayName, null, null, name, mutableMapOf("jira_id" to "0")
+        )
+        imsUser.ims().value = imsProject.ims().value
+        imsUser.template().value = imsUser.ims().value.template().value.imsUserTemplate().value
+        val newUser = neoOperations.save(imsUser).awaitSingle()
+        tokenManager.advertiseIMSUser(newUser)
+        imsProject.ims().value.users() += newUser
+        return newUser
+    }
+
     /**
      * Get a IMSUser for a Jira user
      * @param imsProject the project to map the user to
      * @param user the Jira user
      * @return the IMSUser for the Jira user
      */
     suspend fun mapUser(imsProject: IMSProject, user: JsonElement): User {
-        val encodedAccountId = if (user.jsonObject["accountId"] != null) jsonNodeMapper.jsonNodeToDeterministicString(
-            objectMapper.valueToTree<JsonNode>(user.jsonObject["accountId"]!!.jsonPrimitive.content)
-        )
-        else jsonNodeMapper.jsonNodeToDeterministicString(objectMapper.valueToTree<JsonNode>(user.jsonObject["key"]!!.jsonPrimitive.content))
+        if ((user as? JsonObject) == null) {
+            logger.warn("User is not a JsonObject, falling back to dummy user")
+            return generateNullUser(imsProject, "null-user", "Null User")
+        }
+        val encodedAccountId =
+            if ((user.jsonObject["accountId"] as? JsonPrimitive) != null) jsonNodeMapper.jsonNodeToDeterministicString(
+                objectMapper.valueToTree<JsonNode>(user.jsonObject["accountId"]!!.jsonPrimitive.content)
+            )
+            else if ((user.jsonObject["key"] as? JsonPrimitive) != null) jsonNodeMapper.jsonNodeToDeterministicString(
+                objectMapper.valueToTree<JsonNode>(user.jsonObject["key"]!!.jsonPrimitive.content)
+            )
+            else {
+                logger.warn("User has no key, $user")
+                return generateNullUser(imsProject, "null-id-user", "Null ID User")
+            }
         val foundImsUser =
             imsProject.ims().value.users().firstOrNull { it.templatedFields["jira_id"] == encodedAccountId }
         if (foundImsUser != null) {

sync-jira/src/main/kotlin/gropius/sync/jira/model/IssueData.kt

@@ -145,8 +145,8 @@ class JiraTimelineItem(val id: String, val created: String, val author: JsonObje
         val convInfo =
             timelineItemConversionInformation ?: JiraTimelineItemConversionInformation(imsProject.rawId!!, id);
         val timelineId = timelineItemConversionInformation?.gropiusId
-        val sourceSet = data.fromString!!.split(' ').toSet()
-        val destinationSet = data.toString!!.split(' ').toSet()
+        val sourceSet = (data.fromString ?: "").split(' ').toSet()
+        val destinationSet = (data.toString ?: "").split(' ').toSet()
         logger.info("GOING FROM $sourceSet to $destinationSet, meaning added: ${(destinationSet subtract sourceSet)} and removed ${(sourceSet subtract destinationSet)}")
         for (addedLabel in (destinationSet subtract sourceSet)) {
             val addedLabelEvent = if (timelineId != null) service.neoOperations.findById<AddedLabelEvent>(

sync/src/main/kotlin/gropius/sync/AbstractSync.kt

@@ -498,7 +498,7 @@ abstract class AbstractSync(
         nodesToSave: MutableList<Node>,
         savedNodeHandlers: MutableList<suspend (node: Node) -> Unit>
     ) {
-        logger.info("Syncing incoming for issue ${issue.rawId} $timelineItem ${timelineItem.identification()}")
+        //logger.info("Syncing incoming for issue ${issue.rawId} $timelineItem ${timelineItem.identification()}")
         val oldInfo = collectedSyncInfo.timelineItemConversionInformationService.findByImsProjectAndGithubId(
             imsProject.rawId!!, timelineItem.identification()
         ).firstOrNull()

sync/src/main/kotlin/gropius/sync/HeuristicDereplicator.kt

@@ -64,7 +64,7 @@ class HeuristicDereplicator(val issueThreshold: Double, val commentThreshold: Do
             issueNamedNode.relationshipTo(bodyNamedNode, Issue.BODY).asCondition()
                 .and(issueNamedNode.relationshipFrom(trackableNamedNode, Trackable.ISSUE).asCondition())
         ).toIterable().map { it.rawId!! }.toSet()
-        logger.trace("OTHER ISSUES ${issue.rawId} ${issue.title} $titleMatches $createdByMatches $bodyMatches")
+        //logger.trace("OTHER ISSUES ${issue.rawId} ${issue.title} $titleMatches $createdByMatches $bodyMatches")
         for (otherIssue in otherIssues) {
             if (matchIssue(
                     issue,