-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add puppet8 / data types support #38
base: develop
Are you sure you want to change the base?
Conversation
Any news please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for some unrecognized characters (perhaps ascii vs utf8?) this lgtm.
@ccnifo can we expect a merge + 1.5.0 release? Please?
@ptrsny Hello, sorry for strange characters, it's fixed now. Thanks. |
Hello, any news please ? |
Can the maintainers have a look at this PR? Thanks 👍 |
Any update please ? |
Hi, first of all thanks for the contribution, greatly appreciated Second, sorry for the extreme latency on our side and thanks for your patience. I'll test and validate this PR and come back to you |
@flepoutre can you rebase your branch against our |
normally it's good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review is almost only about data types.
I'm not always sure of what I suggest, this may be subject to interpretation of the krb5.conf(5)
documentation 📖 So feel free to comment if you think I'm wrong
Done. |
Is it ok ? |
Hi @flepoutre Thanks for the initial modifications. There are still a few modifications I was suggesting. You should see them in the files tab. |
Ok thanks. |
Ok, way better 👍 Can you please rebase and squash your commits ? |
No description provided.