Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add puppet8 / data types support #38

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

flepoutre
Copy link

No description provided.

@flepoutre
Copy link
Author

Any news please ?

Copy link

@ptrsny ptrsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for some unrecognized characters (perhaps ascii vs utf8?) this lgtm.
@ccnifo can we expect a merge + 1.5.0 release? Please?

manifests/dbmodules.pp Outdated Show resolved Hide resolved
manifests/realm.pp Outdated Show resolved Hide resolved
@flepoutre
Copy link
Author

@ptrsny Hello, sorry for strange characters, it's fixed now. Thanks.

@flepoutre
Copy link
Author

Hello, any news please ?

@yorickps
Copy link

Can the maintainers have a look at this PR? Thanks 👍

@flepoutre
Copy link
Author

Any update please ?

@riton riton self-assigned this Sep 25, 2024
@riton
Copy link
Member

riton commented Sep 25, 2024

Hi, first of all thanks for the contribution, greatly appreciated

Second, sorry for the extreme latency on our side and thanks for your patience.

I'll test and validate this PR and come back to you

@riton riton changed the base branch from master to develop September 25, 2024 12:22
@riton
Copy link
Member

riton commented Sep 25, 2024

⚠️ I've changed the base branch to our default branch develop instead of the original master . This shouldn't have a huge impact.

@flepoutre can you rebase your branch against our develop and push again ?

@riton riton self-requested a review September 25, 2024 12:43
@flepoutre
Copy link
Author

normally it's good

Copy link
Member

@riton riton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review is almost only about data types.

I'm not always sure of what I suggest, this may be subject to interpretation of the krb5.conf(5) documentation 📖 So feel free to comment if you think I'm wrong

manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/logging.pp Outdated Show resolved Hide resolved
manifests/realm.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/install.pp Outdated Show resolved Hide resolved
manifests/plugins.pp Outdated Show resolved Hide resolved
manifests/plugins.pp Outdated Show resolved Hide resolved
manifests/plugins.pp Outdated Show resolved Hide resolved
@flepoutre
Copy link
Author

Done.

@flepoutre
Copy link
Author

Is it ok ?
Thanks.

@riton
Copy link
Member

riton commented Sep 26, 2024

Hi @flepoutre Thanks for the initial modifications.

There are still a few modifications I was suggesting. You should see them in the files tab.

@flepoutre
Copy link
Author

Ok thanks.
Is it better now ?

@riton
Copy link
Member

riton commented Sep 26, 2024

Ok, way better 👍

Can you please rebase and squash your commits ?

@riton riton changed the title Add puppet8 support Add puppet8 / data types support Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants