Skip to content

Commit

Permalink
Update upload_file return type to dict
Browse files Browse the repository at this point in the history
I just realized `object` is a bit general here: this includes like, any type in python. We expect this method to return a data dictionary - what i'd call an "object" in JavaScript, but python calls a dictionary, so I think we can change this to `dict`.
  • Loading branch information
nikolas authored Jan 13, 2025
1 parent b5eba73 commit c3b5a44
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion s3sign/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def create_presigned_post(s3_client, bucket_name, object_name,
def upload_file(
s3_client, bucket, mime_type, object_name,
max_file_size, acl, expiration_time, private
) -> object:
) -> dict:
S3_BUCKET = bucket
mime_type = mime_type
object_name = object_name
Expand Down

0 comments on commit c3b5a44

Please sign in to comment.