Router.changePage() supports data-transition and data-direction #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth the transition and direction data attributes so we can override the default behaviour.
|
This is a good commit! I just copied and pasted your changes because he still hasn't merged yet. :-/ |
|
👍 on a side note: apparently the syntax for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the changePage() method to parse the attributes of the last anchor tag (a) which the user clicked and extract the
data-transitionanddata-directionvalues so they can be passed to$.mobile.changePage. This allows users to specify these values in their HTML markup.