cleanup: Fix logic for implicit subscriptions #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit subscriptions should be removed once the respective implicator no longer holds.
Exemplarily, for a club newsletter, this ensures that people which became subscribed due to their membership are unsubscribed once it is terminated.
In doing so, this change removes the implicits_only subscription policy, which is redundant to subscribable with this change.
Another way to go about this would be to add another option for an implicit subscription to be "sticky", i.e. to persist after the implicator is lost if the person still has
SubscriptionPolicy.subscribable
.The best way to go about this would be to introduce a new, orthogonal flag,
is_sticky
, which can be passed to_apply_cleanup
and would then replaceand policy.is_implicit()
withand not is_sticky
. In cdedb, this would not be used.What do you think?