Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pTraceShowWith should not call show twice #132

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

leoslf
Copy link
Contributor

@leoslf leoslf commented Dec 14, 2024

Changes

  • fix: pTraceShowWith should pTraceWith instead of pTraceShow since calling pTraceShow after show would make the shown result double-quoted

@cdepillabout
Copy link
Owner

Thanks, this seems to make sense to me.

On master:

> import Debug.Trace
> traceShowWith (+ 1) (100 :: Int)
101
100
> pTraceShowWith (+ 1) (100 :: Int)
"101"
100

With this PR:

> pTraceShowWith (+ 1) (100 :: Int)
101
100

You can see that with this PR, pTraceShowWith doesn't add an extra layer of quoting, in line with traceShowWith.

@cdepillabout cdepillabout merged commit 10a64d3 into cdepillabout:master Dec 16, 2024
14 checks passed
@cdepillabout
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants