Skip to content

Commit

Permalink
chore: fix minor workflow issues
Browse files Browse the repository at this point in the history
  • Loading branch information
xiehan committed Aug 24, 2023
1 parent 311b177 commit a808d03
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/auto-approve.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/automerge.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .github/workflows/upgrade-cdktf.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion projenrc/auto-approve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class AutoApprove {
workflow.addJobs({
approve: {
runsOn: ["ubuntu-latest"],
if: "contains(github.event.pull_request.labels.*.name, 'auto-approve')",
if: "contains(github.event.pull_request.labels.*.name, 'auto-approve') && github.event.pull_request.draft == false",
steps: [
{
name: "Checkout PR",
Expand Down
2 changes: 1 addition & 1 deletion projenrc/automerge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class AutoMerge {
workflow.addJobs({
automerge: {
runsOn: ["ubuntu-latest"],
if: "contains(github.event.pull_request.labels.*.name, 'automerge')",
if: "contains(github.event.pull_request.labels.*.name, 'automerge') && github.event.pull_request.draft == false",
steps: [
{
name: "Checkout",
Expand Down
3 changes: 1 addition & 2 deletions projenrc/upgrade-cdktf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,8 @@ export class UpgradeCDKTF {
"Unfortunately, not everything can be automated, and the following steps need to be completed manually:",
" ",
"- [ ] Update `@cdktf/provider-tfe` to a version compatible with `cdktf@${{ steps.latest_version.outputs.value }}` [here](https://github.com/cdktf/cdktf-multi-stack-tfe/blob/d354d32382b3aa20cdc28c332131d04b730623c0/.projenrc.ts#L36)",
"- [ ] Run `npx projen` again",
" ",
"Please checkout this PR, complete the above steps, push the changes to this PR, and then mark this PR as ready for review to complete the upgrade. Thanks!",
"Please checkout this PR, complete the above steps, push the changes to this branch, and then mark this PR as ready for review to complete the upgrade. Thanks!",
].join("\n"),
labels: "automerge,auto-approve,dependencies",
token: "${{ secrets.PROJEN_GITHUB_TOKEN }}",
Expand Down

0 comments on commit a808d03

Please sign in to comment.