fix: remove icons from alarm descriptions

[patheard]

Summary

Update the alarm descriptions to remove the icons as these are making it harder to determine if it is an ERROR or OK action alarm triggered.

[github-actions]

Production

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 15 to change, 0 to destroy

Show summary

CHANGE	RESOURCE
update	aws_cloudwatch_metric_alarm.superset_ecs_errors["celery-beat"]
	aws_cloudwatch_metric_alarm.superset_ecs_errors["celery-worker"]
	aws_cloudwatch_metric_alarm.superset_ecs_errors["superset"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["celery-beat"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["celery-worker"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["superset"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_memory["celery-beat"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_memory["celery-worker"]
	aws_cloudwatch_metric_alarm.superset_ecs_high_memory["superset"]
	aws_cloudwatch_metric_alarm.superset_load_balancer_healthy_hosts
	aws_cloudwatch_metric_alarm.superset_load_balancer_response_time
	aws_cloudwatch_metric_alarm.superset_load_balancer_unhealthy_hosts
	module.celery_beat_ecs.aws_ecs_service.this
	module.celery_worker_ecs.aws_ecs_service.this
	module.superset_ecs.aws_ecs_service.this

Show plan

Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudwatch_metric_alarm.superset_ecs_errors["celery-beat"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_errors" {
      ~ alarm_description                     = ":warning: celery-beat errors logged over 1 minute." -> "`celery-beat` errors logged over 1 minute."
        id                                    = "errors-celery-beat"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_errors["celery-worker"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_errors" {
      ~ alarm_description                     = ":warning: celery-worker errors logged over 1 minute." -> "`celery-worker` errors logged over 1 minute."
        id                                    = "errors-celery-worker"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_errors["superset"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_errors" {
      ~ alarm_description                     = ":warning: superset errors logged over 1 minute." -> "`superset` errors logged over 1 minute."
        id                                    = "errors-superset"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["celery-beat"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_cpu" {
      ~ alarm_description                     = ":warning: celery-beat high CPU use over 2 minutes." -> "`celery-beat` high CPU use over 2 minutes."
        id                                    = "ecs-celery-beat-high-cpu"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["celery-worker"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_cpu" {
      ~ alarm_description                     = ":warning: celery-worker high CPU use over 2 minutes." -> "`celery-worker` high CPU use over 2 minutes."
        id                                    = "ecs-celery-worker-high-cpu"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_cpu["superset"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_cpu" {
      ~ alarm_description                     = ":warning: superset high CPU use over 2 minutes." -> "`superset` high CPU use over 2 minutes."
        id                                    = "ecs-superset-high-cpu"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_memory["celery-beat"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_memory" {
      ~ alarm_description                     = ":warning: celery-beat high memory use over 2 minutes." -> "`celery-beat` high memory use over 2 minutes."
        id                                    = "ecs-celery-beat-high-memory"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_memory["celery-worker"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_memory" {
      ~ alarm_description                     = ":warning: celery-worker high memory use over 2 minutes." -> "`celery-worker` high memory use over 2 minutes."
        id                                    = "ecs-celery-worker-high-memory"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_ecs_high_memory["superset"] will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_ecs_high_memory" {
      ~ alarm_description                     = ":warning: superset high memory use over 2 minutes." -> "`superset` high memory use over 2 minutes."
        id                                    = "ecs-superset-high-memory"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_load_balancer_healthy_hosts will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_load_balancer_healthy_hosts" {
      ~ alarm_description                     = ":dumpster-fire: there are no healthy hosts for the Superset load balancer in a 1 minute period." -> "There are no healthy hosts for the Superset load balancer in a 1 minute period."
        id                                    = "load-balancer-healthy-hosts"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_load_balancer_response_time will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_load_balancer_response_time" {
      ~ alarm_description                     = ":warning: response time for the Superset load balancer is greater than 1 second over 5 minutes." -> "Response time for the Superset load balancer is greater than 1 second over 5 minutes."
        id                                    = "load-balancer-response-time"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # aws_cloudwatch_metric_alarm.superset_load_balancer_unhealthy_hosts will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "superset_load_balancer_unhealthy_hosts" {
      ~ alarm_description                     = ":warning: there are unhealthy Superset load balancer hosts in a 1 minute period." -> "There are unhealthy Superset load balancer hosts in a 1 minute period."
        id                                    = "load-balancer-unhealthy-hosts"
        tags                                  = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
        # (21 unchanged attributes hidden)
    }

  # module.celery_beat_ecs.aws_ecs_service.this will be updated in-place
  ~ resource "aws_ecs_service" "this" {
        id                                 = "arn:aws:ecs:ca-central-1:066023111852:service/superset/celery-beat"
        name                               = "celery-beat"
        tags                               = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
      ~ task_definition                    = "arn:aws:ecs:ca-central-1:066023111852:task-definition/celery-beat:69" -> "arn:aws:ecs:ca-central-1:066023111852:task-definition/celery-beat:55"
        # (15 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.celery_worker_ecs.aws_ecs_service.this will be updated in-place
  ~ resource "aws_ecs_service" "this" {
        id                                 = "arn:aws:ecs:ca-central-1:066023111852:service/superset/celery-worker"
        name                               = "celery-worker"
        tags                               = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
      ~ task_definition                    = "arn:aws:ecs:ca-central-1:066023111852:task-definition/celery-worker:70" -> "arn:aws:ecs:ca-central-1:066023111852:task-definition/celery-worker:56"
        # (15 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.superset_ecs.aws_ecs_service.this will be updated in-place
  ~ resource "aws_ecs_service" "this" {
        id                                 = "arn:aws:ecs:ca-central-1:066023111852:service/superset/superset"
        name                               = "superset"
        tags                               = {
            "CostCentre" = "cds-superset-prod"
            "Terraform"  = "true"
        }
      ~ task_definition                    = "arn:aws:ecs:ca-central-1:066023111852:task-definition/superset:86" -> "arn:aws:ecs:ca-central-1:066023111852:task-definition/superset:72"
        # (15 unchanged attributes hidden)

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 15 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.athena_bucket.aws_s3_bucket.this,
  on .terraform/modules/athena_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
   8: resource "aws_s3_bucket" "this" {

Use the aws_s3_bucket_lifecycle_configuration resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_elasticache_subnet_group.superset"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.cur_data_extract"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.notify"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.data_export"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.glue_etl"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.glue_s3_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.superset_athena_read"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.data_export"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.glue_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.glue_etl"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.superset_athena_read"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.superset_waf_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_kinesis_firehose_delivery_stream.superset_waf_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.data_export"]

33 tests, 19 passed, 14 warnings, 0 failures, 0 exceptions