This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Fix accessibility in BottomSheet #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytao-me
changed the title
timarney
approved these changes
Jul 6, 2020
henrytao-me
force-pushed
the
issue/432/accessiblity
branch
from
bb3b74a to
c4180d9
Compare
henrytao-me
changed the title
|
Tested on both Android and iOS. I merge this for now. We can do follow up / revert PR if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (hopefully all) accessibility issues related to BottomSheet and content underneath.
To prevent content underneath being read, we need to use
accessibilityElementsHidden(for iOS) orimportantForAccessibility(for Android) when BottomSheet is expanded. Ref https://reactnative.dev/docs/accessibility#accessibilityelementshidden-iosResolves #432