Webpack fix #803
Merged
Webpack fix #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2020 13:16
AntoineAugusti
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding tailwind I had to change up the webpack config. Turns out I didn't quite do it correctly and it was not picking up some styles that go into main.min.js, particularly for the Calendar component.
Closes cds-snc/notification-api#1162
That said, I still would not want to commit main.min.js changes until we remove / fix moment.js (cds-snc/notification-api#1150) as it still adds a lot of garbage to the file. However if it is accidentally committed / updated before that fix happens, it won't break anything this time.
To test:
npm run webpack