Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding debug stack trace feature to celery tasks #1946

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Jul 26, 2023

Summary | Résumé

I've added a debug stack trace task to celery that can be enabled/disabled using the environment variable FF_DEBUG_STACK_TRACE.

When enabled, a celery task will be created that will raise an exception in the same manner as @sastels changes to admin.

Test instructions | Instructions pour tester la modification

  • Set FF_DEBUG_STACK_TRACE to true
  • View the celery logs and make sure the stack trace is shown
  • Set FF_DEBUG_STACK_TRACE to false
  • View the celery logs and make sure the stack trace is not shown, and that the task does not execute at all.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • Is the code maintainable? | Est-ce que le code peut être maintenu?
  • Have you tested it? | L’avez-vous testé?
  • Are there automated tests? | Y a-t-il des tests automatisés?
  • Does this cause automated test coverage to drop? | Est-ce que ça entraîne
    une baisse de la quantité de code couvert par les tests automatisés?
  • Does this break existing functionality? | Est-ce que ça brise une
    fonctionnalité existante?
  • Does this change the privacy policy? | Est-ce que ça entraîne une
    modification de la politique de confidentialité?
  • Does this introduce any security concerns? | Est-ce que ça introduit des
    préoccupations liées à la sécurité?
  • Does this significantly alter performance? | Est-ce que ça modifie de
    façon importante la performance?
  • What is the risk level of using added dependencies? | Quel est le degré de
    risque d’utiliser des dépendances ajoutées?
  • Should any documentation be updated as a result of this? (i.e. README
    setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce
    changement (fichier README, etc.)?

@ben851 ben851 marked this pull request as draft August 2, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants