chore: Refactor ModalRules to use Dialog component #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://6eqt2yhtx3ufppom75elysbp6e0hfpwi.lambda-url.ca-central-1.on.aws/ |
dsamojlenko
changed the title
dsamojlenko
added
the
tech debt
timarney
reviewed
Nov 18, 2024
...s)/[locale]/(form administration)/form-builder/[id]/components/dialogs/RulesDialog/Rules.tsx
Outdated
Show resolved
Hide resolved
timarney
reviewed
Nov 18, 2024
...s)/[locale]/(form administration)/form-builder/[id]/components/dialogs/RulesDialog/Rules.tsx
Outdated
Show resolved
Hide resolved
timarney
reviewed
Nov 18, 2024
...cale]/(form administration)/form-builder/[id]/components/dialogs/RulesDialog/RulesDialog.tsx
Outdated
Show resolved
Hide resolved
timarney
reviewed
Nov 18, 2024
...cale]/(form administration)/form-builder/[id]/components/dialogs/RulesDialog/RulesDialog.tsx
Outdated
Show resolved
Hide resolved
timarney
reviewed
Nov 18, 2024
...cale]/(form administration)/form-builder/[id]/components/dialogs/RulesDialog/RulesDialog.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Converts ModalRules to use the new Dialog component with Event-based trigger.
This is the final legacy Modal to be converted, so this PR also includes removal of the old Modal component and its related files.