Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webserver_logger example, and shutdown events #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GlassOnTin
Copy link

Example added to include logging to the webserver.
Also, added shutdown events so radiacode service stops on exit

@GlassOnTin GlassOnTin closed this Aug 4, 2024
@GlassOnTin GlassOnTin reopened this Aug 4, 2024
@GlassOnTin
Copy link
Author

Also, confirmed this works for the new Radiacode 102/3 models. pyproject.toml description now has "Radiacode-10x"


# Unit test / coverage reports
htmlcov/
.tox/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add only related records or revert this file.

@@ -1,7 +1,7 @@
[tool.poetry]
name = "radiacode"
version = "0.3.3"
description = "Library for RadiaCode-101"
version = "0.3.4"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current release pipeline includes setting an annotated tag and pushing to GitHub to build a pip package with GitHub Actions.
I will publish the release later, so please revert the version bump (but changes in the description are okay).

@@ -0,0 +1,4 @@
#!/usr/bin/bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's your test script, which should not have been committed to the repo.

@@ -0,0 +1,302 @@
<!DOCTYPE html>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can choose a better name for this example. I find the CPS notifications are more important than the logging ability, so maybe choose something neutral or showing both (logs & CPS alerts)?

@cdump
Copy link
Owner

cdump commented Aug 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants