Fix typos found by codespell #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexodia
reviewed
Mar 18, 2024
miasm/analysis/data_flow.py
Outdated
| @@ -1908,9 +1908,9 @@ def __ne__(self, other): | |||
| # required Python 2.7.14 | |||
| return not self == other | |||
|
|
|||
| def may_interfer(self, dsts, src): | |||
| def may_interfere(self, dsts, src): | |||
There was a problem hiding this comment.
I think for this function you should provide a wrapper with the old name (marked as deprecated). This ensures any usages won’t straight up break…
There was a problem hiding this comment.
I'll move this change to a separate PR (#1476).
DimitriPapadopoulos
force-pushed
the
codespell
branch
from
60a9df5
to
46a201e
Compare
|
@serpilliere |
|
Thank you for the fix @DimitriPapadopoulos ! |
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/miasm
that referenced
this pull request
Mar 28, 2024
Fix typos found by codespell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.