A few fixes to the PKGBUILD #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix quotes on conflicts line fix upstream url use zlib instead of libz(aur) add python to depends, remove unnecessary depends bump pkgrel update .SRCINFO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some modifications to the pkgbuild. The single commits are in my rev2_changes branch, if you want to cherry pick. This pull combines the changes.
I'm not sure why the aur package libz was used instead of the repo package zlib. I changed this, as the repo retroarch also uses zlib. This seems to work fine for me.
The changes are:
fix quotes on conflicts line
fix upstream url
use zlib instead of libz(aur)
add python to depends, remove unnecessary depends
bump pkgrel
update .SRCINFO