Fix patch version in unpkg url #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the regex is needed? The fix wouldnt be just put the raw version variable? |
|
I was wondering if the version string would include some extra suffixes as is specified by semver: But I guess the regex approach is still problematic since |
|
Build is broken because of a bug on emscripten: emscripten-core/emscripten#20726 |
|
Merging it because the main is fixed and should build just great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to specify optional patch version in the unpkg url, removing any trailing labels (like
-SNAPSHOTor whatsoever).fix #93