test: fix TestTxPool_ExpiredTxs_Timestamp flake
#1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuantran1702
requested review from
cmwaters and
rach-id
and removed request for
a team
rootulp
changed the title
TestTxPool_ExpiredTxs_Timestamp flake
rootulp
previously approved these changes
Dec 20, 2024
rootulp
approved these changes
Dec 23, 2024
rach-id
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1207
Rationale
After a lot of trial and errors and some research, the rationale behind this change of flaky test is:
Because the TTL is 5ms which is very short, we need to have a more precise pruning interval to ensure that the transactions are expired, so that the expired event is caught quickly enough, while the second batch of transactions are not expired to prevent flaky behaviors.
Testing method
go test -run TestTxPool_ExpiredTxs_Timestamp github.com/tendermint/tendermint/mempool/cat -mod=readonly -race -count 100I run this command 200 times and see no failing one, which is kind of reliable compare to failing rate of 15-20% of old implemetation
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments