Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(share): GetShare -> GetSamples #3905

Merged
merged 11 commits into from
Nov 6, 2024
Merged

refactor(share): GetShare -> GetSamples #3905

merged 11 commits into from
Nov 6, 2024

Conversation

cristaloleg
Copy link
Contributor

Continuation for #3891

@cristaloleg cristaloleg added the kind:refactor Attached to refactoring PRs label Oct 30, 2024
@cristaloleg cristaloleg self-assigned this Oct 30, 2024
cristaloleg
cristaloleg commented Oct 31, 2024
View reviewed changes
blob/service_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan requested changes Oct 31, 2024
View reviewed changes
share/eds/accessor.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Nov 1, 2024
View reviewed changes
share/shwap/p2p/bitswap/sample_block.go Outdated Show resolved Hide resolved
share/eds/rsmt2d.go Outdated Show resolved Hide resolved
store/file/ods.go Outdated Show resolved Hide resolved
@cristaloleg cristaloleg marked this pull request as ready for review November 4, 2024 13:06
Wondertan
Wondertan reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can we avoid changing comments in this PR btw? Would be cool to get to the bottom on why that happened in the first place. Seems like line length misconfiguration

store/store_cache.go Outdated Show resolved Hide resolved
nodebuilder/share/share.go Show resolved Hide resolved
share/eds/testing.go Outdated Show resolved Hide resolved
blob/service_test.go Show resolved Hide resolved
blob/service_test.go Show resolved Hide resolved
blob/service_test.go Show resolved Hide resolved
blob/service_test.go Show resolved Hide resolved
@cristaloleg cristaloleg force-pushed the refactor/continuation-for-3891 branch from 594290b to aab7c15 Compare November 6, 2024 12:57
Wondertan
Wondertan requested changes Nov 6, 2024
View reviewed changes
store/file/ods_q4.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/sample_block.go Outdated Show resolved Hide resolved
store/file/ods.go Outdated Show resolved Hide resolved
Wondertan
Wondertan requested changes Nov 6, 2024
View reviewed changes
share/eds/testing.go Outdated Show resolved Hide resolved
share/shwap/sample_test.go Outdated Show resolved Hide resolved
@cristaloleg cristaloleg merged commit 6f740ac into get-samples Nov 6, 2024
31 checks passed
@cristaloleg cristaloleg deleted the refactor/continuation-for-3891 branch November 6, 2024 14:45
cristaloleg added a commit that referenced this pull request Nov 8, 2024
@cristaloleg
refactor(share): GetShare -> GetSamples (#3905)
da63a3b
cristaloleg added a commit that referenced this pull request Nov 14, 2024
@cristaloleg
refactor(share): GetShare -> GetSamples (#3905)
f823d6b
cristaloleg added a commit that referenced this pull request Nov 19, 2024
@cristaloleg
refactor(share): GetShare -> GetSamples (#3905)
5be2291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay

@vgonkivs vgonkivs Awaiting requested review from vgonkivs

@walldiss walldiss Awaiting requested review from walldiss

Assignees

@cristaloleg cristaloleg

Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristaloleg @Wondertan