-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dummy zk circuits #55
base: main
Are you sure you want to change the base?
Conversation
provers/celestia-prover/.env
Outdated
# SP1_PROVER={network|local|mock} | ||
SP1_PROVER=mock | ||
# Private key with the permission to use the network prover (optional if you use SP1_PROVER=mock) | ||
SP1_PRIVATE_KEY="PRIVATE_KEY" | ||
# Private key which the operator uses to sign the transactions in Eth Sepolia testnet | ||
PRIVATE_KEY="0x82bfcfadbf1712f6550d8d2c00a39f05b33ec78939d0167be2a737d691f33a6a" | ||
# URL of the Tendermint RPC node | ||
TENDERMINT_RPC_URL=http://localhost:5123 | ||
# URL of the Ethereum RPC node | ||
# use https://ethereum-sepolia.publicnode.com/ for the Eth Sepolia testnet | ||
RPC_URL=http://localhost:8545 | ||
# Address of the light client contract | ||
CONTRACT_ADDRESS="0x2854CFaC53FCaB6C95E28de8C91B96a31f0af8DD" | ||
# Address of the E2E test faucet | ||
E2E_FAUCET_ADDRESS="0xaF9053bB6c4346381C77C2FeD279B17ABAfCDf4d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use the .env in the root directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to double check but i can't run the prover anymore. i'll open this pr once i confirm whether i needed this here or not since i don't remember off the top of my head. do you remember generating mock proofs without moving env to prover directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you running the package from the root directory: like cargo run -p celestia-prover
(or whatever the package is called)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run it from inside the package so now I see why I added the env here. I'll remove.
> This gRPC service is still under development and may not work as described | ||
|
||
To run the server you will need to clone the repo and install rust and cargo. To run the node you also need to set the following environment variables: | ||
|
||
- `TENDERMINT_RPC_URL` - the url of the tendermint chain you are proving. | ||
- `RPC_URL` the json rpc url of the evm chain you are generating the proofs for. | ||
|
||
To then run the server (on port `:50051`): | ||
To then run the server (on port `:50001`): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The celestia-prover starts on port 50051 so this change seems like a mistake
To then run the server (on port `:50001`): | |
To then run the server (on port `:50051`): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously it was 50001. there has been some changes since i started working on this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been 50051 since the first celestia-prover PR in this repo: https://github.com/celestiaorg/celestia-zkevm-ibc-demo/pull/33/files#diff-3e3eeb59d344e85d64268133b460af890852ed1aa94c6e049556a9dc3c2aa60cR16
I think it got accidentally modified in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this PR contains commits from a while back so I think it's possible this PR didn't resolve a merge conflict correctly when pulling in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old commits are due to callum initially banrching off of an older working branch. rebasing was a total mess so i merged directly and manually resolved a bunch of conflicts
@@ -4,15 +4,15 @@ The Celestia Prover is a gRPC service that generates zero-knowledge proofs for C | |||
|
|||
## Usage | |||
|
|||
> [!WARNING] | |||
> ⚠️ **Warning** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] the previous renders nicely on Github but I'm fine w/ either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is due to merge. this pr is still a wip.
Overview