Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forward port ledger fixes #358

Closed
wants to merge 2 commits into from
Closed

chore: forward port ledger fixes #358

wants to merge 2 commits into from

Conversation

cmwaters
Copy link

* fix: bump ledger-cosmos-go

* feat: update cosmos-sdk code for ledger-cosmos-go

Inspired by cosmos#14661
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Cosmos SDK major release is main in this repo based on?

@@ -18,7 +18,7 @@ require (
github.com/cosmos/cosmos-sdk/db v1.0.0-beta.1
github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/iavl v0.19.6
github.com/cosmos/ledger-cosmos-go v0.12.2
github.com/cosmos/ledger-cosmos-go v0.13.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.13.2 should work but in a follow up PR we should probably bump to https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.13.3

@cmwaters cmwaters changed the title chore: forward prt ledger fixes chore: forward port ledger fixes Nov 15, 2023
@cmwaters
Copy link
Author

What Cosmos SDK major release is main in this repo based on?

Still v0.46. It was cut from releases/v0.46.x-celestia. Actually I brought it up in slack that given we don't plan to break anything (i.e. we will use version based if statements) that it would be okay to just use the single branch and thus we don't need main

@rootulp
Copy link
Collaborator

rootulp commented Nov 15, 2023

oh awesome, that makes things easier to track. Does that mean we don't need this PR?

@rootulp rootulp mentioned this pull request Nov 16, 2023
@cmwaters
Copy link
Author

Closing since we are planning on deprecating the main branch

@cmwaters cmwaters closed this Nov 20, 2023
@rootulp rootulp deleted the cal/forward-port branch November 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants