Initial docs, cargo fmt, and move toward env vars over clap
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
force-pushed
the
n/init-docs
branch
from
72e3830 to
6e00fc2
Compare
nuke-web3
commented
Jan 23, 2025
| @@ -1,25 +1,27 @@ | |||
| [workspace] | |||
| members = ["service", "program-keccak-inclusion", "common", "blob-tool", "runner-keccak-inclusion"] | |||
| default-members = ["service"] | |||
There was a problem hiding this comment.
so cargo run knows what bin to execute in the workspace
|
thanks, will review soon today |
S1nus
reviewed
Jan 24, 2025
| .await | ||
| .expect("Failed getting header"); | ||
|
|
||
| let commitment = Commitment::new( | ||
| hex::decode(&args.commitment) | ||
| .expect("Invalid commitment hex") | ||
| base64::engine::general_purpose::STANDARD |
There was a problem hiding this comment.
can you make it do either hex or base64? Maybe try hex first and if it fails try base64?
S1nus
reviewed
Jan 24, 2025
S1nus
reviewed
Jan 24, 2025
S1nus
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Initial README (rendered w/ diagram here) plus some cleanup:
<Maj>.<Min>)cargo fixto cleanup warningsPart of a solution for #9