Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version - celestia app charts #84

Merged
merged 13 commits into from
Dec 11, 2024
Merged

Initial version - celestia app charts #84

merged 13 commits into from
Dec 11, 2024

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented Dec 3, 2024

Overview

tty47 added 5 commits November 26, 2024 18:29
@tty47
feat(app): celestia-app chart + common - initial commit
d6dc5ca 
Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47
feat(app): perms fixes and updtes
f76b400 
Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47
feat: update values
a72ab46 
Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47
feat: update values
05fa26f 
Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47
feat: update values
70734e8 
Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47 tty47 requested review from smuu and a team December 3, 2024 15:52
MSevey
MSevey requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions on some of the versions.

charts/celestia-app/Chart.yaml Show resolved Hide resolved
charts/celestia-app/README.md Outdated Show resolved Hide resolved
charts/celestia-node/README.md Outdated
@@ -1,6 +1,6 @@
# celestia-node

![Version: 0.10.3](https://img.shields.io/badge/Version-0.10.3-informational?style=flat-square) ![AppVersion: v0.20.1](https://img.shields.io/badge/AppVersion-v0.20.1-informational?style=flat-square)
![Version: 0.10.5](https://img.shields.io/badge/Version-0.10.5-informational?style=flat-square) ![AppVersion: v0.20.2](https://img.shields.io/badge/AppVersion-v0.20.2-informational?style=flat-square)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node is on 20.4 right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be auto updated with the scripts maybe? since we would be setting the versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump the docs, there's already a script to do so, I'll add it to the makefile to also run it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one: https://github.com/celestiaorg/helm-charts/blob/main/scripts/gen_helm_docs.sh

charts/celestia-node/README.md Outdated Show resolved Hide resolved
charts/celestia-node/README.md Outdated Show resolved Hide resolved
MSevey
MSevey previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are documentation related. Don't need to block.
Test it and find the bugs next week on Arabica 😛

@tty47 tty47 merged commit d1a8dd7 into main Dec 11, 2024
1 of 2 checks passed
@tty47 tty47 deleted the jose/app-chart branch December 11, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey left review comments

@smuu smuu Awaiting requested review from smuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tty47 @MSevey