Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for interactive environment testing #84

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

mbabadi
Copy link
Collaborator

@mbabadi mbabadi commented Sep 11, 2024

The previous test was not working in Google Colab. I have tested the new code in IPython, Jupyter Lab, Jupyter Notebook, Colab, and in shell (non-interactive). It works as expected.

Copy link
Collaborator

@nmalfroy nmalfroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmalfroy
Copy link
Collaborator

Though it looks like you've got some linting errors

@mbabadi mbabadi merged commit f8e852b into main Sep 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants