Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-70 Bump version of pydantic #86

Merged
merged 1 commit into from
Sep 17, 2024
Merged

CAS-70 Bump version of pydantic #86

merged 1 commit into from
Sep 17, 2024

Conversation

nmalfroy
Copy link
Collaborator

@nmalfroy nmalfroy commented Sep 16, 2024

This was because pydantic doesn't provide doc-compatible version in python<3.7

Copy link
Collaborator

@KevinCLydon KevinCLydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Version specific dependencies is a neat feature

@nmalfroy
Copy link
Collaborator Author

I thought so! Might get to be a bit unwieldy at some point but for now it's great

Copy link
Collaborator

@fedorgrab fedorgrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pydantic==2.5.3;python_version<="3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't know you could do that, that's pretty cool to know!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!?

@nmalfroy nmalfroy merged commit 65c8c87 into main Sep 17, 2024
5 checks passed
@nmalfroy nmalfroy deleted the nm-fix-build branch September 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants