Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check to see if target exists before deleting #370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

awwwd
Copy link

@awwwd awwwd commented Oct 19, 2022

Signed-off-by: awwwd [email protected]

Fixes #109

API Validation in Postman

target1 exists in project1 but target2 doesn't
image

Now, Let's try to delete target2 to validate the PR changes
image

As we can see -- it's giving us 404 Not Found-

{
    "error_message": "target does not exist"
}

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@awwwd awwwd changed the title fix: check to see if it exists before deleting fix: check to see if target exists before deleting Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #370 (4566905) into main (45f292b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   70.02%   70.18%   +0.16%     
==========================================
  Files          11       11              
  Lines        2042     2053      +11     
==========================================
+ Hits         1430     1441      +11     
  Misses        510      510              
  Partials      102      102              
Impacted Files Coverage Δ
service/handlers.go 62.22% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f292b...4566905. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting a target, check to see if it exists first
3 participants