Soloseng/L2-Accounts-test #11268
Merged
Soloseng/L2-Accounts-test #11268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-chrzan
approved these changes
Nov 14, 2024
| @@ -80,13 +79,11 @@ contract AccountsTest is Test, TestConstants { | |||
| event PaymentDelegationSet(address indexed beneficiary, uint256 fraction); | |||
|
|
|||
| function setUp() public { | |||
| deployCodeTo("Registry.sol", abi.encode(false), REGISTRY_ADDRESS); | |||
| setupRegistry(); | |||
There was a problem hiding this comment.
Utils setUp now sets up the registry, so can just use super.setUp().
Suggested change
| setupRegistry(); | |
| super.setUp(); |
| @@ -200,7 +193,12 @@ contract AccountsTest is Test, TestConstants { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| contract TransitionToL2AfterL1 is AccountsTest { | |||
There was a problem hiding this comment.
Use the new WhenL2 pattern, see e.g. in Validators test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setup Accounts test for L2
Related issues