Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Gauge: Add support for constant labels #468

Merged
merged 4 commits into from
Apr 4, 2019
Merged

Gauge: Add support for constant labels #468

merged 4 commits into from
Apr 4, 2019

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 requested a review from songy23 April 3, 2019 22:07
@codecov-io
Copy link

codecov-io commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #468 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage    94.7%   94.66%   -0.05%     
==========================================
  Files         150      150              
  Lines        9780     9683      -97     
  Branches      732      744      +12     
==========================================
- Hits         9262     9166      -96     
+ Misses        518      517       -1
Impacted Files Coverage Δ
src/detect-resource.ts 66.66% <0%> (-26.2%) ⬇️
test/test-detect-resource.ts 93.84% <0%> (-5.68%) ⬇️
src/metrics/gauges/gauge.ts 100% <0%> (ø) ⬆️
src/grpc-stats/server-stats.ts 100% <0%> (ø) ⬆️
src/resource-labels.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
test/test-derived-gauge.ts 100% <0%> (ø) ⬆️
src/grpc-stats/common-distributions.ts 100% <0%> (ø) ⬆️
src/metrics/metric-registry.ts 100% <0%> (ø) ⬆️
test/test-gauge.ts 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f219ec7...d6f208e. Read the comment docs.

draffensperger
draffensperger approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some optional/style nits

packages/opencensus-core/src/common/validations.ts Outdated Show resolved Hide resolved
packages/opencensus-core/src/common/validations.ts Outdated Show resolved Hide resolved
packages/opencensus-core/src/common/validations.ts Outdated Show resolved Hide resolved
packages/opencensus-core/src/metrics/gauges/derived-gauge.ts Outdated Show resolved Hide resolved
@mayurkale22
Gauge: Add support for constant labels
4190a66
@mayurkale22
update CHANGELOG.md
2737d8d
@mayurkale22
fix review comments
4fc9abc 
1. Remove map -> constantLabels
2. Make labels values and keys merging code consistent.
3. Update error message
@mayurkale22 mayurkale22 merged commit 6f5c6b3 into census-instrumentation:master Apr 4, 2019
@mayurkale22 mayurkale22 deleted the customLabels branch April 4, 2019 20:56
@mayurkale22 mayurkale22 mentioned this pull request Apr 8, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 26, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songy23 songy23 songy23 approved these changes

@draffensperger draffensperger draffensperger approved these changes

@justindsmith justindsmith Awaiting requested review from justindsmith

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayurkale22 @codecov-io @draffensperger @songy23 @googlebot