This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Plug-in Cumulative APIs into the Metric-Registry #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 94.58% 95.02% +0.43%
==========================================
Files 145 145
Lines 10195 10224 +29
Branches 875 890 +15
==========================================
+ Hits 9643 9715 +72
+ Misses 552 509 -43
Continue to review full report at Codecov.
|
draffensperger
approved these changes
May 8, 2019
| * useful when you want to manually increase and reset values as per service | ||
| * requirements. | ||
| * | ||
| * @param {string} name The name of the metric. |
There was a problem hiding this comment.
What would you think about removing these types in the JSDoc that are the same as the TS types?
| * useful when you want to manually increase and reset values as per service | ||
| * requirements. | ||
| * | ||
| * @param {string} name The name of the metric. |
There was a problem hiding this comment.
Same here on types in JSDoc
mayurkale22
force-pushed
the
hook_cumulative_api_to_registry
branch
from
e2a3251
to
09f17ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #450
Registering Derived Cumulative APIs with Metric-Registry will be in a follow-up PR. Dependency on #503