This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
feat(span): make tracer available on span #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekike
requested review from
draffensperger,
justindsmith and
mayurkale22
as code owners
hekike
force-pushed
the
feat/tracer-on-span
branch
from
b2b19b9
to
5bca0ab
Compare
| @@ -31,6 +29,8 @@ export class NoRecordRootSpan extends NoRecordSpan { | |||
| * parent was likely started on another machine. | |||
| */ | |||
| private parentSpanIdLocal: string; | |||
| /** A tracer object */ | |||
| tracer: types.TracerBase; | |||
There was a problem hiding this comment.
Could this be readonly? (Applies to other uses below too)
draffensperger
approved these changes
Jul 15, 2019
mayurkale22
approved these changes
Jul 16, 2019
|
Please update the CHANGELOG with new feat. |
|
@mayurkale22 I added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making tracer always available on spans would make it easier to create child spans from existing span instances when you pass your span around.
Further explanation:
open-telemetry/opentelemetry-specification#21