[wip] cleanup local dev ux #11
Conversation
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref || github.run_id }}-${{ inputs.brand_name}}-${{ inputs.stream_name }} | ||
| group: ${{ github.workflow }}-${{ github.ref || github.run_id }} |
There was a problem hiding this comment.
Dropping this for now, we can re-add it if needed in the future
| alias_tags="$(just generate-build-tags \ | ||
| "latest" \ | ||
| "1" \ | ||
| "$(podman inspect ${{ env.IMAGE_NAME }}:${{ env.DEFAULT_TAG }} | jq -r '.[].Config.Labels["org.opencontainers.image.version"]')" \ | ||
| "${{ github.event_name }}" \ | ||
| "${{ github.event.number }}")" | ||
|
|
||
| echo "Tags for this Action..." | ||
| echo "$alias_tags" | ||
| echo "alias_tags=${alias_tags}" >> $GITHUB_OUTPUT | ||
|
|
||
| # Tag Images | ||
| - name: Tag Images | ||
| shell: bash | ||
| run: | | ||
| set -eoux pipefail | ||
| just tag-images "${{ env.IMAGE_NAME }}" \ | ||
| "${{ env.DEFAULT_TAG }}" \ | ||
| "${{ steps.generate-tags.outputs.alias_tags }}" |
There was a problem hiding this comment.
Pulled this back into the github action workflow, since it's not needed for local dev.
| export repo_organization := env("GITHUB_REPOSITORY_OWNER", "centos-workstation") | ||
| export image_name := env("IMAGE_NAME", "main") | ||
| export centos_version := env("CENTOS_VERSION", "stream10") | ||
| export default_tag := env("DEFAULT_TAG", "latest") |
There was a problem hiding this comment.
streamline variable config between what's being set in github actions and here.
| shell: bash | ||
| run: | | ||
| IMAGE_FULL="${{ steps.registry_case.outputs.lowercase }}/${IMAGE_NAME}" | ||
| just build "${IMAGE_FULL}" "${DEFAULT_TAG}" |
There was a problem hiding this comment.
We need to refactor the build-vm and run-vm ones after this gets merged. This will kind of break it I think..?
There was a problem hiding this comment.
That's the main reason this is still wip, but wanted to get this pushed before I called it a night
There was a problem hiding this comment.
Worst case dont worry we can work on it outside of this PR. I want to keep the achillobator just run-vm 1 raw workflow, it is super cleeeean!
There was a problem hiding this comment.
build-vm and run-vm recipes are working now. I did refactor run-vm to run in a container (blatantly stolen from the bluefin run-iso job)
WIP refactor of some of the local dev experience
Example run from my fork (fails on cosign): https://github.com/detiber/chonky-main/actions/runs/12405816581/job/34633290193