Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vmware8-esx): add MVP modes #5482

Merged
merged 16 commits into from
Mar 4, 2025

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Mar 3, 2025

Description

New modes

  • Cpu
  • Memory
  • Power

Factorized code

  • api.pm: all generic functions to use the VMware8 Rest API
  • esx/mode.pm: all functions to use the VMware8 Rest API that are specific to physical hosts

Enhancements

  • The previously existing Host-Status has been adapted to fit the functions defined in both api.pm and esx/mode.pm.

About tests

  • In host-status.robot, all tests are performed with both LWP and curl backends.
  • Cpu has two separate test files to check with both backends

Refs: CTOR-430

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier marked this pull request as ready for review March 3, 2025 16:32
@omercier omercier requested review from a team as code owners March 3, 2025 16:32
@omercier omercier requested a review from Evan-Adam March 4, 2025 10:14
@omercier omercier force-pushed the CTOR-430-VMWare8-MVP-modes-Pack-ESX branch from e711f8c to 8b2333c Compare March 4, 2025 10:25
@Evan-Adam Evan-Adam merged commit a7d4d51 into develop Mar 4, 2025
61 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-430-VMWare8-MVP-modes-Pack-ESX branch March 4, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants