feat: Add delta compression support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added test-cases from https://github.com/dchest/fossil-delta-js/tree/master/test |
|
Hello @itismoej ! Many thanks! I reviewed changes here, the algorithm works as expected. Opened a separate PR based on top of your PR with some tweaks: #21 - please take a look. In contains a couple of important fixes and changes: take a look at commit 8fb4d82 - basically, the same thing as in Java regarding recovery publication processing, also some tweaks in codec implementation. Tests are passing locally now with the latest code of Centrifugo, but fail in CI since based on the released version (5.4.5). As soon as we release new Centrifugo version (5.4.6, will try early upcoming week) - tests should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a way to set new Subscription delta option:
Option delta can only have fossil value now (delta compression based on Fossil algorithm).
When set, client will try to negotiate delta compression in channel with a server. If server allows this delta type – messages in channel MAY be delta-compressed. Whether messages are delta compressed or not depends on server publishing logic.